Update scripts/configs for Windows nightly/release builds. #3040
+2,250
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_702368570
branch
5 times, most recently
from
a359454 to
764ab06
Compare
copybara-service
bot
force-pushed
the
test_702368570
branch
3 times, most recently
from
4ba88f6 to
b64d47d
Compare
`set -u` (does not allow unbound variables) has been removed from all scripts. This is due to Docker on Windows treating variables in an env file, set to an empty value (`MY_VAR=`), as unbound variables. Consequently, these variables, even though they are "set", do not make it into the Docker container at all, and various checks for those variables fail outright. PiperOrigin-RevId: 702368570
copybara-service
bot
force-pushed
the
test_702368570
branch
from
b64d47d to
1242e6c
Compare
copybara-service
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update scripts/configs for Windows nightly/release builds.
set -u(does not allow unbound variables) has been removed from all scripts.This is due to Docker on Windows treating variables in an env file,
set to an empty value (
MY_VAR=), as unbound variables. Consequently,these variables, even though they are "set", do not make it into the Docker
container at all, and various checks for those variables fail outright.